Skip to content

Added model "LearningLIFFloat" to make API hardware agnostic. #535

Merged
weidel-p merged 2 commits intomainfrom
fix/learning_lif
Dec 9, 2022
Merged

Added model "LearningLIFFloat" to make API hardware agnostic. #535
weidel-p merged 2 commits intomainfrom
fix/learning_lif

Conversation

@weidel-p
Copy link
Copy Markdown
Contributor

@weidel-p weidel-p commented Dec 9, 2022

Issue Number:

Objective of pull request:

As we introduced a LearningLIF Process, we also need one for floating point simulations. This PR adds that and also adds a test for it.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • [ x Docs reviewed and added / updated if needed (for bug fixes / features)
  • [x]PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

Copy link
Copy Markdown
Contributor

@gkarray gkarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in a previous meeting, all good!

@bala-git9 bala-git9 self-requested a review December 9, 2022 16:26
@weidel-p weidel-p merged commit 88f419c into main Dec 9, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants