Compiler graph: Enable model selection, fixing warning in QUBU tutorial. Now with same default ProcModels#435
Merged
srrisbud merged 7 commits intolava-nc:mainfrom Oct 24, 2022
phstratmann:main
Merged
Compiler graph: Enable model selection, fixing warning in QUBU tutorial. Now with same default ProcModels#435srrisbud merged 7 commits intolava-nc:mainfrom phstratmann:main
srrisbud merged 7 commits intolava-nc:mainfrom
phstratmann:main
Conversation
try fix failing unit test by specifying select_tag="floating_pt"
mathisrichter
approved these changes
Oct 24, 2022
srrisbud
approved these changes
Oct 24, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…al. Now with same default ProcModels (lava-nc#435) * fixed model selection * minor lintin * Update test_models.py try fix failing unit test by specifying select_tag="floating_pt" * corrected ipykernel in jupyter notebook * corrected compiler_graphs, this time without breaking change Co-authored-by: PhilippPlank <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: 420
Objective of pull request:
ProcModel search throws error if a module imports a ProcModel.
Previous fix broke unit tests in lava collab.
This fix passes also on collab, as it provides the same default ProcModels as the previous code.