Fixing np.logical_and/or problems in Connection ProcessModels#412
Merged
PhilippPlank merged 3 commits intomainfrom Oct 14, 2022
Merged
Fixing np.logical_and/or problems in Connection ProcessModels#412PhilippPlank merged 3 commits intomainfrom
PhilippPlank merged 3 commits intomainfrom
Conversation
bala-git9
approved these changes
Oct 13, 2022
PhilippPlank
approved these changes
Oct 14, 2022
Contributor
PhilippPlank
left a comment
PhilippPlank
left a comment
There was a problem hiding this comment.
This should work and is faster and as long as the arrays are only boolean it is the same behavior.
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…c#412) * fixing np.logical_and/or problems * fixing linting issues Co-authored-by: gkarray <[email protected]> Co-authored-by: PhilippPlank <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: #411
Objective of pull request: Fixing incorrect use of np.logical_and and np.logical_or was discovered in learning-related code in Connection ProcessModels.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
andandorelement-wise operations on 3np.ndarray(example :a,bandc), the following is used :np.logical_and(a, b, c)What is the new behavior?
a & b & cDoes this introduce a breaking change?