Merged
Conversation
Changed calculation of wrapped_current.
fixed linting
2 tasks
PhilippPlank
requested review from
GaboFGuerra,
ashishrao7,
drager-intel,
mathisrichter and
mgkwill
GaboFGuerra
approved these changes
Sep 23, 2022
Contributor
GaboFGuerra
left a comment
GaboFGuerra
left a comment
There was a problem hiding this comment.
Thanks Philipp, not sure if there should be a test added or affected by this.
mgkwill
approved these changes
Sep 23, 2022
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Update models.py Changed calculation of wrapped_current. * Update models.py fixed linting * Remove unused sign_of_curr from models.py Co-authored-by: Marcus G K Williams <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed calculation of wrapped_current.
Issue Number: #334
Objective of pull request: Fix subthr_dynamics() function for fixed point lif model so that neuron current wraps to opposite side of integer range rather than to 0.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information