Stochastic Constraint Integrate and Fire (SCIF) neuron model for constraint satisfaction problems#335
Merged
srrisbud merged 8 commits intolava-nc:mainfrom Sep 21, 2022
Merged
Conversation
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
srrisbud
requested review from
GaboFGuerra,
ashishrao7,
awintel and
phstratmann
Signed-off-by: Risbud, Sumedh <[email protected]>
phstratmann
reviewed
Sep 8, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
reviewed
Sep 9, 2022
phstratmann
approved these changes
Sep 9, 2022
Contributor
phstratmann
left a comment
phstratmann
left a comment
There was a problem hiding this comment.
Was a pleasure to review your code: easy to read, well documented, well tested.
Only very minor style suggestions. Feel free to implement or ignore.
GaboFGuerra
approved these changes
Sep 12, 2022
Contributor
GaboFGuerra
left a comment
GaboFGuerra
left a comment
There was a problem hiding this comment.
Thanks Sumedh! just remove the zombie code PS mentioned in test_models.py.
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…traint satisfaction problems (lava-nc#335) * SCIF neuron model for QUBO, CSP, etc. Signed-off-by: Risbud, Sumedh <[email protected]> * SCIF neuron model for QUBO, CSP, etc. Signed-off-by: Risbud, Sumedh <[email protected]> * Minor import fix Signed-off-by: Risbud, Sumedh <[email protected]> * SCIF: Enabled QUBO support Signed-off-by: Risbud, Sumedh <[email protected]> Signed-off-by: Risbud, Sumedh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number:
Objective of pull request:
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information