Skip to content

Changes in DiGraphBase class to enable recurrence#273

Merged
mgkwill merged 2 commits intolava-nc:mainfrom
srrisbud:enable_recurrence
Jul 20, 2022
Merged

Changes in DiGraphBase class to enable recurrence#273
mgkwill merged 2 commits intolava-nc:mainfrom
srrisbud:enable_recurrence

Conversation

@srrisbud
Copy link
Copy Markdown
Contributor

Signed-off-by: Risbud, Sumedh [email protected]

Objective of pull request:
Modifications to DiGraphBase class to enable recurrent topologies

Pull request checklist

Your PR fulfills the following requirements:

  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applies BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Feature

What is the current behavior?

  • When collapsing a cycle to a single node, DiGraphBase's method did not treat single-node-self-recurrent cycles correctly.

What is the new behavior?

  • Changes to the collapsing code fix the issue.

Does this introduce a breaking change?

  • No

@PhilippPlank PhilippPlank added the area: magma/compiler Issues with something in lava/magma/compiler label Jul 19, 2022
@mgkwill mgkwill added 1-bug Something isn't working 1-feature New feature request reviewed-approved labels Jul 20, 2022
@mgkwill mgkwill merged commit df8b984 into lava-nc:main Jul 20, 2022
@srrisbud srrisbud deleted the enable_recurrence branch July 21, 2022 22:30
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-bug Something isn't working 1-feature New feature request area: magma/compiler Issues with something in lava/magma/compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants