Merged
Conversation
weidel-p
approved these changes
Jun 10, 2022
Contributor
weidel-p
left a comment
weidel-p
left a comment
There was a problem hiding this comment.
This PR only changes two lines, setting the post_guard instead of the pre_guard and calling run_post_mgmt instead of run_pre_mgmt. That's fine for me.
mathisrichter
approved these changes
Jun 10, 2022
2 tasks
|
Is there a reason why the |
Contributor
Author
|
They work, but to do what the tutorial is supposed to do, we would also need the lrn_guard to return true. The pre_mgmt phase is coupled with learning enabled. |
|
Thanks a lot for clarifying! |
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Bugfix for the tutorial07_remote_memory_access.ipynb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: #249
Objective of pull request: Tutorial07 should work again
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information