Skip to content

Fixed reset timing offset#207

Merged
bamsumit merged 1 commit intolava-nc:mainfrom
bamsumit:scratch
Mar 2, 2022
Merged

Fixed reset timing offset#207
bamsumit merged 1 commit intolava-nc:mainfrom
bamsumit:scratch

Conversation

@bamsumit
Copy link
Copy Markdown
Contributor

@bamsumit bamsumit commented Mar 2, 2022

Signed-off-by: bamsumit [email protected]

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • io.reset timing is off by 1 step compared to dataset and read processes

What is the new behavior?

  • io.reset behaves same as dataset and read processes

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit bamsumit self-assigned this Mar 2, 2022
@bamsumit bamsumit linked an issue Mar 2, 2022 that may be closed by this pull request
7 tasks
@bamsumit bamsumit requested a review from ysingh7 March 2, 2022 19:29
Copy link
Copy Markdown
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bamsumit bamsumit merged commit 27898a7 into lava-nc:main Mar 2, 2022
@bamsumit bamsumit deleted the scratch branch March 2, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IO Reset timing is off by 1

3 participants