RefPort's sometimes handled a time step late#205
Merged
PhilippPlank merged 42 commits intolava-nc:mainfrom Mar 2, 2022
Merged
Conversation
…ta is serviced before the process finishes (which blocks advancing a time step and ensures all VarPorts on the receiving process will be serviced beforehand).
7 tasks
PhilippPlank
added
1-bug
awintel
requested changes
Mar 1, 2022
Contributor
awintel
left a comment
awintel
left a comment
There was a problem hiding this comment.
Looks fine. But you should update the docstring.
bamsumit
approved these changes
Mar 2, 2022
Contributor
|
Tested it out on PN SNN notebook. The the results are consistent. |
- added wait() to the dataloader - modified docstring of wait
awintel
approved these changes
Mar 2, 2022
Contributor
awintel
left a comment
awintel
left a comment
There was a problem hiding this comment.
I would still recommend to improve the docstring.
The fundamental behavior of the RefPort should be explained in the class docstring.
Approving anyways since this is just a style issue that can be fixed later. Just don't forget about it.
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* - Introducing of a wait() method for RefPorts makes sure that sent data is serviced before the process finishes (which blocks advancing a time step and ensures all VarPorts on the receiving process will be serviced beforehand). * - optimized Reset by not using a read() to get the data shape - added wait() to the dataloader - modified docstring of wait * - modified docstring of wait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: #204
Objective of pull request: Deterministic behavior of when data sent via a RefPort is received by the target process. Occasionally it was possible that the receiving process moved to the next phase before all of its VarPorts got serviced, because sending data via a RefPort does not block. Introducing of a wait() method for RefPorts makes sure that sent data is serviced before the process finishes (which blocks advancing a time step and ensures all VarPorts on the receiving process will be serviced beforehand).
Pull request checklist
Your PR fulfills the following requirements:
pyb) passes locallypyb -E unit) or (python -m unittest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information