[Model] isCoinStakeMine method validating against the tx input instead of the output.

furszy · furszy · commit 79d131d49f73 · 2019-09-06T11:56:05.000-03:00
diff --git a/src/qt/walletmodel.cpp b/src/qt/walletmodel.cpp
@@ -466,7 +466,7 @@ bool WalletModel::isCoinStakeMine(QString id){
     uint256 hashTx;
     hashTx.SetHex(id.toStdString());
     const CWalletTx* tx = getTx(hashTx);
-    return tx->IsCoinStake() && wallet->IsMine(tx->vout[1]) == ISMINE_ALL;
+    return tx->IsCoinStake() && wallet->IsMine(tx->vin[0]);
 }
 
 bool WalletModel::mintCoins(CAmount value, CCoinControl* coinControl ,std::string &strError){
@@ -493,9 +493,6 @@ bool WalletModel::createZpivSpend(
         value += pair.second;
     }
 
-    // Default: assume something goes wrong. Depending on the problem this gets more specific below
-    int nStatus = ZPIV_SPEND_ERROR;
-
     if (wallet->IsLocked()) {
         receipt.SetStatus("Error: Wallet locked, unable to create transaction!", ZPIV_WALLET_LOCKED);
         return false;
