chore: refactor for removing pdb symbols #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
requested changes
Aug 23, 2023
Member
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
This is good, just some minor nits on the chosen names, but otherwise fine.
Please add your sign-off tag to the commit.
Member
|
@peppelinux any chance you can fix the nits and push anew? I'd like to merge this. |
Contributor
Author
|
Ciao @simo5 |
Member
|
@peppelinux great, would you mind squashing the commits together, I will then merge. |
simo5
approved these changes
Nov 29, 2023
Member
|
Uhmm sounds like the linter is not happy, if "aa" does not work, feel free to change to "aad" |
Contributor
Author
|
Done @simo5 ! |
simo5
requested changes
Nov 29, 2023
Member
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
Unfortunately the linter is still not 100% happy, 4 places need to change ai->aad
simo5
approved these changes
Dec 7, 2023
Member
simo5
left a comment
simo5
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents an easy refactor of small parts of the source code where the PDB symbols was used for variable assignments. It simply removed the variable names
a,cthat are used in PDB to inspect the args and continue the execution.Closes #327 (comment)