Fix typo in new backwards JWT compat heuristics #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Argh, and of course this is one of the heuristics I forogt to add a test for ... |
Member
|
Would you mind adding a test in the tests file which checks this condition? I will release 1.4.2 right after we get this in, sigh. |
Signed-off-by: Simo Sorce <[email protected]>
Member
|
NVM, I could not resist and pushed a commit on your branch, so I can deal with this quickly |
Member
|
Thanks for spotting this, very appreciated |
Contributor
Author
|
No, no, thank you for working on this, promptly writing a test case and getting this merged and released in absolutely no time. I merely spotted the issue ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that the test suite of a package I'm working on are suddenly failing. Short digging later, there was a typo in the newly released 1.4.1