Add fix for CVE-2022-3102 #299
Merged
+124
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to address CVE-2022-3102. Thanks to Tom tervoort from Secura for finding and reporting this issue. Also test that "unepxected" token types are not validated Signed-off-by: Simo Sorce <[email protected]>
Because the previous patch changes the behavoir of jwcrypto, this knob is a quick way for application developers to get back the old behavior temporarily without having to change the code immediately as it may require some significant refactoring, depending on how the application was written. This is not intended to be used in the long term and will be eventually deleted. Unfortunately I cannot decorate a simply global variable with the @deprecated decoration to make it clearer. Signed-off-by: Simo Sorce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this fix technically breaks the current JWT api.
unfortunately there was no way to address this weakness without a change in semantics.
This means some applications may throw exceptions in some cases that were previously handled.
A knob to alter this behavior has been provided for applications that can't immediately refactor but still wants a way to upgrade t later jwcrypto releases.