Repository navigation
fix(desktop): quit-warning test fake provides system languages - #648
Merged
Merged
Conversation
Upstream added preferredSystemLanguages to the ElectronApp service and updated its own fakes, but the carried "warns with the running Action count before quitting" test builds its own fake, so the desktop typecheck fails. Carry-Group: incubator Co-Authored-By: Claude <[email protected]>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastcode/mainfails the@t3tools/desktoptypecheck. Upstream pingdotgg#32035 addedpreferredSystemLanguagesto theElectronAppservice and updated its own test fakes. The carried "warns with the running Action count before quitting" test inDesktopLifecycle.test.tsbuilds its own fake, which is now missing the property. Every Quick CI run fails its recursive typecheck as a result.This adds the property to that fake. The desktop typecheck and the lifecycle tests (9/9) pass, and local Quick CI passes on this head.
Full CI didn't catch this: since upstream moved the desktop, web and marketing
typechecktasks intovite.config, it no longer typechecks those packages. That gap is fixed in a separate PR.Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code