Repository navigation
fix(provider): allow new directories through workspace aliases - #266
Merged
lastobelus merged 1 commit intoOct 3, 2026
Merged
Conversation
Carry-Group: upstream-bugfixes Carry-Observation: Resolve the nearest existing ancestor before checking canonical workspace containment for new client files. Carry-Upstream: pingdotgg#15154 at 2ef98ce
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity rejects valid new files beneath a workspace alias when their parent directories do not exist. This breaks ordinary writes on macOS, where temporary paths resolve through a canonical alias.
Resolve the nearest existing ancestor before appending missing components and checking workspace containment. Existing and dangling symlinks remain checked and outside-workspace requests remain rejected. Add a regression covering a workspace alias with two new directory levels.
Independent upstream contribution: pingdotgg#15154 (head 2ef98ce).
Validation: all eight focused adapter tests and exact-head Quick CI passed.
Implemented with GPT-6.1-Sol through the Codex harness.