Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use command parameter files when compiling on Windows #791

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Use command parameter files when compiling on Windows #791

merged 1 commit into from
Aug 10, 2023

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Aug 9, 2023 •
edited
Loading

Hopefully this fixed our Windows release builds. TensorFlow has the same setting enabled.

A test release is currently running here.

@lgeiger lgeiger requested a review from a team August 9, 2023 18:50
@lgeiger lgeiger added the internal-improvement Internal Improvements and Maintenance label Aug 9, 2023
Tombana
Tombana approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@Tombana Tombana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's working. The job failed due to a timeout, but I've restarted them now.

relatively short limit

I'm not sure if 32K is short, I think TF just has long commandlines 😅

@lgeiger lgeiger merged commit 3beb3bf into main Aug 10, 2023
@lgeiger lgeiger deleted the fix-windows-build branch August 10, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tombana Tombana Tombana approved these changes

@CNugteren CNugteren CNugteren approved these changes

Assignees
No one assigned
Labels
internal-improvement Internal Improvements and Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgeiger @Tombana @CNugteren