Split Python interpreter in two classes #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CNugteren
approved these changes
Jul 26, 2021
lgeiger
reviewed
Jul 29, 2021
Comment on lines
+22
to
-58
| See the base class `InterpreterBase` for the full interface. | ||
|
|
||
| # Arguments | ||
| flatbuffer_model: A serialized Larq Compute Engine model in the flatbuffer format. | ||
| num_threads: The number of threads used by the interpreter. | ||
| use_reference_bconv: When True, uses the reference implementation of LceBconv2d. | ||
|
|
||
| # Attributes | ||
| input_types: Returns a list of input types. | ||
| input_shapes: Returns a list of input shapes. | ||
| output_types: Returns a list of output types. | ||
| output_shapes: Returns a list of output shapes. |
There was a problem hiding this comment.
Can we add the Attributes, here again since they appear in our docs?
There was a problem hiding this comment.
Won't the docs pick it up from the base class?
There was a problem hiding this comment.
Unfortunately I don't think so, it just parses the markdown.
There was a problem hiding this comment.
I've moved it: #677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This splits the
Interpreterpython class inInterpreterBase(python-only) andInterpreter(including the C++ module). The base class is also used by our private interpreters, and this split avoids their dependency on the full LCE interpreter.How Has This Been Tested?
CI covers this.