Fork ConvertTFExecutorToTFLOrFlatbuffer to re-enable argname truncation
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
commented
May 21, 2021
| /*select_user_tf_ops=*/{}, quant_specs, /*saved_model_tags=*/{}, &result, | ||
| &pm); | ||
| auto status = ConvertTFExecutorToFlatbuffer( | ||
| module->get(), /*export_to_mlir=*/false, &result, &pm); |
There was a problem hiding this comment.
I kept the export_to_mlir option since it might come in handy for debugging later on.
There was a problem hiding this comment.
That's amazing, I'm always searching for that option when I want to write new Filecheck tests.
AdamHillier
approved these changes
May 21, 2021
lgeiger
force-pushed
the
fork-tf_tfl_flatbuffer
branch
from
1020eb9 to
816432b
Compare
Tombana
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR forks
ConvertTFExecutorToTFLOrFlatbufferto allow us to re-enable arg name truncation.How Has This Been Tested?
CI
Related issue number
Fixes #628 (comment)