-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bitpacked activation optimisations by default. #597
Conversation
dc8b9b2
to
f1cc36e
Compare
Move the bitpacked-activation rewrite pattern in the converter from C++ to TableGen.
f1cc36e
to
45505ab
Compare
For Aarch32 would this correctly fallback to the reference implementation? If this is the case I actually would be slightly in favour of enabling bitpacked activations by default and open an issue to add support for bitpacked activations to the Aarch32 optimized kernels. @AdamHillier @Tombana what do you think? |
I'm fairly sure it will fall back to reference kernels but will check. If so, I agree that we should do that. I also think that adding Aarch32 support for optimised bitpacked output shouldn't be too hard. |
I have merged in the latest changes and updated this branch accordingly. @lgeiger perhaps you could take another look at the code and make a final decision on whether we can merge this in. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, from my side! Thanks for updating the PR @CNugteren
What do these changes do?
This PR moves the bitpacked-activations converter rewrite pattern from C++ to TableGen, and enables it by default.
How Has This Been Tested?
CI.
Benchmark Results
N/A.
Related issue number
N/A.