Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __version__ property. #543

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add __version__ property. #543

merged 1 commit into from
Oct 22, 2020

Conversation

AdamHillier
Copy link
Contributor

@AdamHillier AdamHillier added the internal-improvement Internal Improvements and Maintenance label Oct 21, 2020
@AdamHillier AdamHillier requested a review from a team October 21, 2020 18:06
AdamHillier
AdamHillier commented Oct 21, 2020
View reviewed changes
larq_compute_engine/mlir/python/converter_test.py Outdated
assert (
hasattr(larq_compute_engine, "__version__")
and "." in larq_compute_engine.__version__
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgeiger is this test failing because we don't actually install the package, so setup.py isn't being run?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we don't actually install LCE in the Python only tests since it would require us to build all the C++ dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, then I think I'll just remove the test because I don't think there's much extra value including it.

@lgeiger lgeiger merged commit e7b3c4f into master Oct 22, 2020
@lgeiger lgeiger deleted the version-attr branch October 22, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
internal-improvement Internal Improvements and Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamHillier @lgeiger