Skip to content

Fix BatchWatcher::recordBatch docblock copied from JobWatcher - #1753

Merged
taylorotwell merged 1 commit into
laravel:5.xfrom
darkdi:fix/batchwatcher-docblock
Aug 5, 2026
Merged

taylorotwell merged 1 commit into
laravel:5.xfrom
darkdi:fix/batchwatcher-docblock

Conversation

@darkdi

@darkdi darkdi commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

BatchWatcher::recordBatch() carries the docblock of JobWatcher::recordJob().

/**
 * Record a job being created.
 *
 * @param  string  $connection
 * @param  string  $queue
 * @param  array  $payload
 * @return \Laravel\Telescope\IncomingEntry|null
 */
public function recordBatch(BatchDispatched $event)

The method takes a single BatchDispatched $event. recordJob($connection, $queue, array $payload) in JobWatcher.php:58 really does take those three, and its block is correct — this one was copied across and never adjusted, summary line included.

Replaced the three tags with the parameter the method actually takes, and made the summary say batch rather than job.

Docblock only, no behaviour change.

@taylorotwell
taylorotwell merged commit 67edf6c into laravel:5.x Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants