Skip to content

Comments

[8.x] Fixed DocBlocks#1187

Merged
taylorotwell merged 8 commits intolaravel:8.xfrom
dunhamjared:8.x
Sep 3, 2021
Merged

[8.x] Fixed DocBlocks#1187
taylorotwell merged 8 commits intolaravel:8.xfrom
dunhamjared:8.x

Conversation

@dunhamjared
Copy link
Contributor

@dunhamjared dunhamjared commented Sep 2, 2021

  • Replaced @inheritDoc -- missing parent member with doc comments
  • Updated docblock for gatherMiddlewareClassNames -- the $middleware parameter can handle arrays and the callLumenControllerWithMiddleware function passes an array

@taylorotwell
Copy link
Member

taylorotwell commented Sep 2, 2021

Please always use fully qualified class names in doc blocks.

@driesvints driesvints marked this pull request as draft September 3, 2021 06:20
@driesvints
Copy link
Member

driesvints commented Sep 3, 2021

Mark this as ready when you've converted to FQN, thanks.

@dunhamjared
Copy link
Contributor Author

dunhamjared commented Sep 3, 2021 •
edited
Loading

Ok, I sifted through the src directory and found a few more doc blocks that needed fully qualified class names.

Also discovered two more @inheritdoc that were missing parent members with doc comments.

@dunhamjared dunhamjared marked this pull request as ready for review September 3, 2021 15:08
@taylorotwell taylorotwell merged commit f5ae0d0 into laravel:8.x Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dunhamjared @taylorotwell @driesvints