Repository navigation
[13.x] Fix parallel testing with PHPUnit 13.4 - #61859
Merged
taylorotwell merged 1 commit intoOct 5, 2026
Merged
Conversation
crynobone
reviewed
Oct 4, 2026
| : $this->options->configuration(); | ||
|
|
||
| (new PhpHandler())->handle($configuration->php()); | ||
| (new PhpHandler(EventFacade::emitter()))->handle($configuration->php()); |
Member
There was a problem hiding this comment.
wouldn't this failed on PHPUnit 13.3 and below?
Contributor
Author
There was a problem hiding this comment.
It won't. PhpHandler has no constructor before 13.4, so PHP just ignores the extra argument. I checked it on 13.3.6, and 11.5 and 12.5 don't have one either.
cursor Bot
pushed a commit
to DevanB/kibbles
that referenced
this pull request
Oct 10, 2026
Laravel 13.34 still constructs PhpHandler with no arguments. The official fix is 13.35 (laravel/framework#61859), which this repo cannot take until Wayfinder accepts QUERY. Temporarily classmap Illuminate\Testing\ParallelRunner to Laravel's one-line emitter fix so the existing test:unit command keeps working. Co-authored-by: Devan <[email protected]>
DevanB
added a commit
to DevanB/kibbles
that referenced
this pull request
Oct 10, 2026
Laravel 13.34 still constructs PhpHandler with no arguments. The official fix is 13.35 (laravel/framework#61859), which this repo cannot take until Wayfinder accepts QUERY. Temporarily classmap Illuminate\Testing\ParallelRunner to Laravel's one-line emitter fix so the existing test:unit command keeps working. Co-authored-by: Devan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 13.4 added a required
Emitterargument toPhpHandler's constructor, sophp artisan test --parallelnow fails with anArgumentCountErrorbefore any test runs.This passes
PHPUnit\Event\Facade::emitter(), which is what PHPUnit itself hands it. Older PHPUnit versions have no constructor onPhpHandler, so the extra argument is ignored there and 11.x/12.x keep working as before.Fixes #61857