[12.x] Add support for Enums in Translator replacements #58048
Merged
+62
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using PHP Enums as values in the translator’s replacement array.
Right now, if an Enum is passed to the
replacesarray, the translator tries to treat the Enum object as a string. That causes aTypeErrorwhenmb_substr()is called. For example:Because of:
framework/src/Illuminate/Translation/Translator.php
Lines 292 to 293 in eb14349
The change updates
Translator::makeReplacements()so that Enum values are converted to their underlying value before the replacement logic runs. This brings Enum handling in line with how other simple value types are treated.Tests are included for string-backed, int-backed, and unit Enums.
No breaking changes.