[12.x] Add commandFileFinder method and exclude test files from command discovery #58017
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi All, I upgraded to the latest version (12.42.0) and my "development:test" command is no longer found. When I reverted back to 12.41.1 it worked fine. I am wondering if this new feature is causing the issue? ERROR Command "development:test" is not defined. Did you mean one of these? (my thought would be that this would have been backwards compatible as it took me a while after my upgrade to figure out why my commands were not working) Thanks for all you do. -Rob |
|
@streamingsystems see #58106 (comment) for a solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
commandFileFindermethod to the console Kernel and updates the command discovery logic to exclude test files by default.Changes
commandFileFinder(array $paths)method that returns theFinderinstance used for discovering command filesloadmethod to use$this->commandFileFinder($paths)instead of directly instantiating the Finder*Test.phpare now excluded from command auto-discovery by defaultBenefits to End Users
Fixes PHPUnit ignoring co-located test files - When developers co-locate PHPUnit test files alongside their command classes in the
Commandsfolder, the command discovery mechanism autoloads these test files before PHPUnit runs. This causes PHPUnit to skip them entirely since the classes are already loaded. By excluding*Test.phpfiles from command discovery, tests are properly executed by PHPUnit.Extensibility - Developers can now override
commandFileFinder()in their application's Kernel to customize which files are discovered (e.g., exclude additional patterns, include specific directories, etc.)