[12.x] Allow float values in duration helpers for CarbonInterval #58006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
While I agree that it should support what Carbon supports, your example is quite contrived. Instead of
would just do seconds($expectedSeconds) |
Contributor
Author
Agreed, although they are only completely the same after calling Either way, this PR will indeed add support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the duration helpers (
microseconds,milliseconds,seconds,minutes,hours,days) to acceptint|floatvalues.CarbonInterval natively supports fractional values for all of these units (as reflected in its docblock for the corresponding
add{Unit}methods), and the conversion is internally handled through microseconds. Updating the helpers aligns Laravel’s type signatures with Carbon’s documented behavior.Why?
Developers often work with derived or calculated durations, for example:
Without float support, this requires extra casting:
Allowing floats removes unnecessary boilerplate and matches the actual capabilities of CarbonInterval.
Benefits