[13.x] Default PendingRequest@pool() to use 2 for concurrency
#57972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
commented
Nov 29, 2025
Comment on lines
+3530
to
+3537
| [$exception] = $this->factory->pool(function (Pool $pool) { | ||
| return [ | ||
| $pool->get('https://laravel.com'), | ||
| ]; | ||
| }); | ||
|
|
||
| $this->assertInstanceOf(StrayRequestException::class, $exception); | ||
| $this->assertEquals('Attempted request to [https://laravel.com] without a matching fake.', $exception->getMessage()); |
Contributor
Author
There was a problem hiding this comment.
I modified this test to match how we are testing other pooled exceptions in this file. The exception was being thrown because the pool was running in series rather than actually as a pool. This behavior better lines up with how it should be used (in my opinion).
Member
|
I'm not sure I'm seeing them execute serially on my end. For instance, on my machine this does not take 5 seconds: <?php
use Illuminate\Http\Client\Pool;
use Illuminate\Support\Benchmark;
use Illuminate\Support\Facades\Http;
use Illuminate\Support\Facades\Route;
Route::get('/', function () {
$time = Benchmark::measure(function () {
$responses = Http::pool(fn (Pool $pool) => [
$pool->get('http://laravel.test/test'),
$pool->get('http://laravel.test/test'),
$pool->get('http://laravel.test/test'),
$pool->get('http://laravel.test/test'),
$pool->get('http://laravel.test/test'),
]);
dump(collect($responses)->map(fn ($response) => (string) $response));
});
dd($time);
});
Route::get('/test', function () {
sleep(1);
return (string) random_int(1, 100);
}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that this defaults to null feels like a major footgun. Developers will think that they are getting the benefit of concurrent requests when in fact they are just being executed in series. Within the underlying Guzzle library, passing null does mean to execute without a cap.
Is 2 the right number? I have no idea. But I think anything is better than just defaulting to serial execution. Or we could change it to pass
0which I think would allow for unbounded concurrency.