[12.x] Fix creating and filling a model instance twice for every record #57799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
riesjart
commented
Nov 16, 2025
| * @return array | ||
| */ | ||
| protected function getAttributesForInsert() | ||
| public function getAttributesForInsert() |
Contributor
Author
There was a problem hiding this comment.
Made public so it can be called from the factory for clarity.
Contributor
There was a problem hiding this comment.
These would be breaking changes if anyone happened to extend these classes and modify the functions, no? Might have to target master in that case.
Member
|
Will try @cosmastech's fix since it's non-breaking. Thanks. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Eloquent
Factory::insert()method currently instantiates and fills a model twice for every record, which I think seems inefficient. More importantly it unnecessarily casts raw attribute values back and forth to eventually insert them, which I think is an anti-pattern.One of the issues this causes has been pointed out here. This PR aims to fix this issue of double quoting of array casted JSON columns, as an alternative to #57794.