@cosmastech I tried this change locally in our project, and it causes errors in some tests, for example a test that renders a page containing a NoCaptcha from the https://github.com/anhskohbo/no-captcha package.

Specifically on GuzzleHttp\Client::__construct(): Argument #1 ($config) must be of type array, null given from Anhskohbo\NoCaptcha\NoCaptchaServiceProvider::register()

    public function register()
    {
        $this->app->singleton('captcha', function ($app) {
            return new NoCaptcha(
                $app['config']['captcha.secret'],
                $app['config']['captcha.sitekey'],
                $app['config']['captcha.options']
            );
        });
    }

This test works fine with $this->markConfigCached($app);

@cosmastech I tried this change locally in our project, and it causes errors in some tests, for example a test that renders a page containing a NoCaptcha from the https://github.com/anhskohbo/no-captcha package.

Specifically on GuzzleHttp\Client::__construct(): Argument #1 ($config) must be of type array, null given from Anhskohbo\NoCaptcha\NoCaptchaServiceProvider::register()

    public function register()
    {
        $this->app->singleton('captcha', function ($app) {
            return new NoCaptcha(
                $app['config']['captcha.secret'],
                $app['config']['captcha.sitekey'],
                $app['config']['captcha.options']
            );
        });
    }

This test works fine with $this->markConfigCached($app);

Thanks for reporting this @SanderMuller. I will mark this as draft and continue my spelunking.

Our application has multiple parallel connections (to make it work we used the steps in this tutorial) but after this change our test suite breaks. I think it currently doesn't work with multiple connections.

Our application has multiple parallel connections (to make it work we used the steps in this tutorial) but after this change our test suite breaks. I think it currently doesn't work with multiple connections.

Yes, as noted above, the ParallelTestRunner isn't designed out of the box to work with multiple connections. Strangely enough, we have (almost) this exact tutorial code in our codebase. For whatever reason, we never ran into the parallel runner problem that others reported.

Can you try adding this to your extended service provider, replacing your testDatabaseOnConnection() method?

    private static array $connectionMap = [];
    protected function testDatabaseOnConnection(string $connection): string
    {
        if (! isset(self::$connectionMap[$connection])) {
            self::$connectionMap[$connection] = config("database.connections.$connection.database");
        }

        self::$originalDatabaseName = self::$connectionMap[$connection];

        return $this->testDatabase(config("database.connections.$connection.database"));
    }

Thanks @cosmastech! It sadly didn't work. I don't have time to investigate further, but from a quick test I see that the underlying testDatabase method is still being called somewhere and returning a stale database name.

I've 'solved' it for now by overwriting the testDatabase function and keeping it's original behavior:

protected function testDatabase($database): string
{
    $token = ParallelTesting::token();

    return "{$database}_test_{$token}";
}

Thanks @cosmastech! It sadly didn't work. I don't have time to investigate further, but from a quick test I see that the underlying testDatabase method is still being called somewhere and returning a stale database name.

I've 'solved' it for now by overwriting the `testDatabase` function and keeping it's original behavior:

protected function testDatabase($database): string
{
    $token = ParallelTesting::token();

    return "{$database}_test_{$token}";
}

Glad you've got it working for the time being. 👍