Don't call Model::toArray() to get attributes for factory insert #57670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That seems to make sense. It would prevent Model's defined that have |
This was referenced Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57600 introduced an
insertmethod for the Eloquent model factory.I don't think it should call
Model::toArray()to collect the model attributes for insertion. For multiple reasons, one of them beingtoArray()will also include any loaded relations.I think calling
Model::getAttributesForInsert()instead would be preferred, but since this method is protected and only callsModel::getAttributes(), I chose the latter. I think it might be better to makegetAttributesForInsert()public if there's no objection to that.