[11.x] Add a method to connection for driver and version comparison#49723
Closed
hafezdivandari wants to merge 3 commits intolaravel:masterfrom
Closed
[11.x] Add a method to connection for driver and version comparison#49723hafezdivandari wants to merge 3 commits intolaravel:masterfrom
hafezdivandari wants to merge 3 commits intolaravel:masterfrom
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
staudenmeir
reviewed
Jan 17, 2024
gocanto
reviewed
Jan 18, 2024
Member
|
I dunno - I think our current code is pretty fine? |
Contributor
Author
|
Current code just works, but we need single source of truth for driver and version comparison. Also the package developers (and end-users on some scenarios) gonna need this regarding the changes on 11.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determining database driver and version to handle different databases' capabilities is tricky, this PR adds a new
ismethod toConnectionfor convenient driver and version comparison.Usage
Almost all these syntaxes are currently used on the framework:
Why?
The best reason is the changed code of this PR. We need this method to check driver and actual version of the database to handle different grammar syntaxes, features and capabilities of each one.
Support
Supported drivers are based on the current usage on the framework,
maridb,mysql,sqlite,pgsql,sqlsrvandvitess(i.e PlanetScale).Other databases (e.g. SingleStoreDB, CockroachDB, Supabase, etc.) may be added later.