Skip to content

Comments

[10.x] Revert 47763 fix sql server#47792

Merged
taylorotwell merged 4 commits intolaravel:10.xfrom
dunhamjared:revert-47763-fix_sql_server
Jul 24, 2023
Merged

[10.x] Revert 47763 fix sql server#47792
taylorotwell merged 4 commits intolaravel:10.xfrom
dunhamjared:revert-47763-fix_sql_server

Conversation

@dunhamjared
Copy link
Contributor

@dunhamjared dunhamjared commented Jul 21, 2023

Overview

This PR reverts breaking changes made on PR #47763 that are causing the following SQL Server errors: https://github.com/laravel/framework/actions/runs/5576994989/job/15101561407

I think the original author of the PR is working on a different fix for this issue.

Updates

  • Reverted breaking changes
  • Re-enabled SQL Server workflow tests

@taylorotwell taylorotwell merged commit 289298e into laravel:10.x Jul 24, 2023
@dunhamjared dunhamjared deleted the revert-47763-fix_sql_server branch July 24, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants