Fixes the issue of running docs command on windows#43566
Merged
taylorotwell merged 2 commits intolaravel:9.xfrom Aug 5, 2022
mahmoudmohamedramadan:9.x
Merged
Fixes the issue of running docs command on windows#43566taylorotwell merged 2 commits intolaravel:9.xfrom mahmoudmohamedramadan:9.x
docs command on windows#43566taylorotwell merged 2 commits intolaravel:9.xfrom
mahmoudmohamedramadan:9.x
Conversation
Member
|
Thank for looking at this @mahmoudmohamedramadan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version of that charming command was not working on Windows (my OS type), it was opening CMD only not the browser as it should have done so, I tried to change
escapeshellargstoescapeshellcmdand FINALLY, it works perfectly 🎉In the old version
was using
startONLY on my OS so, the command was run perfectly.In the new version
When @timacdonald introduces a new PR, the command is getting to use a full path for an executable file like
C:\Program Files\Git\usr\bin\start.COMbut, this command does not work perfectly on my OS so, I introduce this PR to solveThe command "C:\Program Files\Git\usr\bin\start.COM https://laravel.com/docs/9.x/views" failed. I see it's IMPORTANT to check about the executable file as he has done but, then we can use the keywords according to OS type likeopen,startwithescapeshellcmdfunction to make sure that the command will work perfectly.