[9.x] Support modifying a char column type#41320
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Mar 3, 2022
hafezdivandari:9.x
Merged
[9.x] Support modifying a char column type#41320taylorotwell merged 1 commit intolaravel:9.xfrom hafezdivandari:9.x
taylorotwell merged 1 commit intolaravel:9.xfrom
hafezdivandari:9.x
Conversation
Member
|
Can you describe how you determined these changes were needed and what the problem was before this fix? |
Member
|
Please mark as ready once you have done so. |
Contributor
Author
|
@taylorotwell sure, I updated my comment above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides support for modifying a
charcolumn type.Before this PR, modifying a
charcolumn led to an error:But
doctrine/dbalpackage actually supports modifyingcharcolumn types asStringType::classby settingfixedoption totrue.So this PR, maps Laravel
charto its Doctrine equivalentstringtype and setfixedoption totruethat finally gets the SQL snippet to declare a CHAR column.