Skip to content

[8.x] Make mailable assertions fluent#38850

Merged
taylorotwell merged 1 commit intolaravel:8.xfrom
macbookandrew:feature/fluent-mailable-assertions
Sep 17, 2021
Merged

[8.x] Make mailable assertions fluent#38850
taylorotwell merged 1 commit intolaravel:8.xfrom
macbookandrew:feature/fluent-mailable-assertions

Conversation

@macbookandrew
Copy link
Contributor

@macbookandrew macbookandrew commented Sep 17, 2021

This adds a bit of nice DX so mailable assertions are fluent similar to HTTP assertions.

Before:

$mail = new WelcomeEmail($user);

$mail->assertSeeInHtml('Welcome, '.$user->name.'!');
$mail->assertSeeInText('Welcome, '.$user->name.'!');

After:

$mail = new WelcomeEmail($user);

$mail
    ->assertSeeInHtml('Welcome, '.$user->name.'!')
    ->assertSeeInText('Welcome, '.$user->name.'!');

// Alternative

(new WelcomeEmail($user))
    ->assertSeeInHtml('Welcome, '.$user->name.'!')
    ->assertSeeInText('Welcome, '.$user->name.'!');

@taylorotwell taylorotwell merged commit 8fafa89 into laravel:8.x Sep 17, 2021
@andrewminion-luminfire andrewminion-luminfire deleted the feature/fluent-mailable-assertions branch September 17, 2021 17:48
@GrahamCampbell GrahamCampbell changed the title [8.x] - make mailable assertions fluent [8.x] Make mailable assertions fluent Sep 17, 2021
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
@macbookandrew @victorvilella
make mailable assertions fluent (laravel#38850)
b1a645b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macbookandrew @taylorotwell

Comments