[6.x] Add test for event payload of type object#31477
Merged
taylorotwell merged 1 commit intolaravel:6.xfrom Feb 14, 2020
Merged
[6.x] Add test for event payload of type object#31477taylorotwell merged 1 commit intolaravel:6.xfrom
taylorotwell merged 1 commit intolaravel:6.xfrom
Conversation
GrahamCampbell
changed the title
voku
added a commit
to voku/framework
that referenced
this pull request
Feb 15, 2020
* upstream/master: (78 commits) [7.x] Implement anonymous components (laravel#31363) Apply fixes from StyleCI (laravel#31480) Apply fixes from StyleCI (laravel#31479) revert broken table feature move files add test for event payload of type object (laravel#31477) [7.x] Refactor route caching (laravel#31188) [6.x] Fixes appendRow on console table (laravel#31469) Apply fixes from StyleCI (laravel#31474) formatting Throw exception on empty collection (laravel#31471) Add tests for Query Builder when array value given (laravel#31464) Remove addHidden method (laravel#31463) allow afterResponse chain add getRawOriginal Remove unused use-statement Update comment [6.x] Change MySql nullable modifier to allow generated columns to be not null (laravel#31452) [6.x] Test for pushed events (laravel#31451) Fixed phpdoc ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we do not have any tests for events of type objects to check that their payload is not the second parameter passed to the dispatch method, but it is the event object itself.
In other words, this part of the framework can be ruined undetected.
