[6.x] Change MySql nullable modifier to allow generated columns to be not null#31452
Merged
taylorotwell merged 2 commits intolaravel:6.xfrom Feb 13, 2020
DrCake:allow_not_null_generated_columns
Merged
[6.x] Change MySql nullable modifier to allow generated columns to be not null#31452taylorotwell merged 2 commits intolaravel:6.xfrom DrCake:allow_not_null_generated_columns
taylorotwell merged 2 commits intolaravel:6.xfrom
DrCake:allow_not_null_generated_columns
Conversation
Member
Contributor
Author
|
@staudenmeir mentioned in this issue #31398 that it's because we need to keep the old functionality to be able to support MariaDB. |
voku
added a commit
to voku/framework
that referenced
this pull request
Feb 15, 2020
* upstream/master: (78 commits) [7.x] Implement anonymous components (laravel#31363) Apply fixes from StyleCI (laravel#31480) Apply fixes from StyleCI (laravel#31479) revert broken table feature move files add test for event payload of type object (laravel#31477) [7.x] Refactor route caching (laravel#31188) [6.x] Fixes appendRow on console table (laravel#31469) Apply fixes from StyleCI (laravel#31474) formatting Throw exception on empty collection (laravel#31471) Add tests for Query Builder when array value given (laravel#31464) Remove addHidden method (laravel#31463) allow afterResponse chain add getRawOriginal Remove unused use-statement Update comment [6.x] Change MySql nullable modifier to allow generated columns to be not null (laravel#31452) [6.x] Test for pushed events (laravel#31451) Fixed phpdoc ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses this issue where it is impossible to make a MySql generated column be
not null.I ran into this issue when trying to run this migration:
which fails when trying to add the spatial index as it cannot be added to a 'nullable' column.
The change allows using the existing functionality of the
nullable()method where you can pass false as the parameter to explictly mark the column as not null. This should hopefully limit the effect this change has on existing migrations by not changing the normal behaviour.With this change, the migration would work by using this for the 'location' column