[7.x] Use valid methods when array value given for Query Builder where method#31323
Closed
mnabialek wants to merge 2 commits intolaravel:masterfrom
Closed
[7.x] Use valid methods when array value given for Query Builder where method#31323mnabialek wants to merge 2 commits intolaravel:masterfrom
mnabialek wants to merge 2 commits intolaravel:masterfrom
Conversation
…od for some operators
Member
|
We already have a whereIn method that should be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems at the moment Query Builder silently chooses only 1st value from array when array value given. There is no exception thrown so this could lead to potential risky situations when code doesn't behave as it should if by mistake you pass array to
wheremethod.For example at the moment when you use code like this:
builder will generate queries like those:
If this PR were accepted in case of developer error using such code, Builder would automatically fallback to
whereInandwhereNotInmethods when possible.I believe this change could potentially affect existing applications so it's better to target it to 7.x instead of 6.x