Merged
Conversation
| { | ||
| $this->app->singleton('migration.creator', function ($app) { | ||
| return new MigrationCreator($app['files']); | ||
| return new MigrationCreator($app['files'], $app->basePath('stubs')); |
Contributor
There was a problem hiding this comment.
This change pretty much broke my package that relied on resolving the MigrationCreator (do believe my usage of this class wasn't perfect in any sense), is there a reason for the MigrationCreator to be bound to migration.creator instead of MigrationCreator::class which would make it resolveable from the container via IoC? @driesvints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #31052. It fixes the tests and replaces the used helpers by the already resolved Laravel instance. I had to update the
MigrationCreatorto make the tests pass.