Skip to content

Fix Fatal error on Class 'Illuminate\Filesystem' load#2

Merged
taylorotwell merged 1 commit intolaravel:masterfrom
flaviozantut:master
Jan 11, 2013
Merged

Fix Fatal error on Class 'Illuminate\Filesystem' load#2
taylorotwell merged 1 commit intolaravel:masterfrom
flaviozantut:master

Conversation

@flaviozantut
Copy link
Copy Markdown
Contributor

Fix Fatal error on Class 'Illuminate\Filesystem' not found in /vendor/laravel/framework/src/Illuminate/Workbench/Starter.php on line 16

Fix Fatal error on Class 'Illuminate\Filesystem' not found in /vendor/laravel/framework/src/Illuminate/Workbench/Starter.php on line 16
taylorotwell added a commit that referenced this pull request Jan 11, 2013
Fix Fatal error on Class 'Illuminate\Filesystem' load
@taylorotwell taylorotwell merged commit afbb5e8 into laravel:master Jan 11, 2013
@spinegar spinegar mentioned this pull request Apr 1, 2013
ethaizone added a commit to ethaizone/framework that referenced this pull request Jul 1, 2013
Obfuscate to only characters < 128. For protect this method will break UTF-8 string.
@bachmacintosh bachmacintosh mentioned this pull request Oct 9, 2014
@kirkbushell kirkbushell mentioned this pull request Nov 24, 2014
taylorotwell pushed a commit that referenced this pull request Nov 26, 2014
LukeTowers added a commit to LukeTowers/framework that referenced this pull request Jul 23, 2025
Fixes laravel#56152 which was caused by the incorrect parameters being used for a more specific type hint docblock merged in laravel#55687. 

This currently causes issues with projects that use static analysis and make use of the $builder->blueprintResolver() method to resolve custom blueprints.

Example below:

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   Database/DatabaseServiceProvider.php                                                                      
 ------ ---------------------------------------------------------------------------------------------------------- 
  :109   Parameter laravel#1 $connection of class Winter\Storm\Database\Schema\Blueprint constructor expects              
         Illuminate\Database\Connection, string given.                                                             
         🪪  argument.type                                                                                         
  :109   Parameter laravel#2 $table of class Winter\Storm\Database\Schema\Blueprint constructor expects string, Closure   
         given.                                                                                                    
         🪪  argument.type                                                                                         
  :109   Parameter laravel#3 $callback of class Winter\Storm\Database\Schema\Blueprint constructor expects Closure|null,  
         string given.                                                                                             
         🪪  argument.type                                                                                         
 ------ ----------------------------------------------------------------------------------------------------------
taylorotwell pushed a commit that referenced this pull request Jul 23, 2025
* Fix incorrect docblock for custom builder resolvers

Fixes #56152 which was caused by the incorrect parameters being used for a more specific type hint docblock merged in #55687. 

This currently causes issues with projects that use static analysis and make use of the $builder->blueprintResolver() method to resolve custom blueprints.

Example below:

 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   Database/DatabaseServiceProvider.php                                                                      
 ------ ---------------------------------------------------------------------------------------------------------- 
  :109   Parameter #1 $connection of class Winter\Storm\Database\Schema\Blueprint constructor expects              
         Illuminate\Database\Connection, string given.                                                             
         🪪  argument.type                                                                                         
  :109   Parameter #2 $table of class Winter\Storm\Database\Schema\Blueprint constructor expects string, Closure   
         given.                                                                                                    
         🪪  argument.type                                                                                         
  :109   Parameter #3 $callback of class Winter\Storm\Database\Schema\Blueprint constructor expects Closure|null,  
         string given.                                                                                             
         🪪  argument.type                                                                                         
 ------ ----------------------------------------------------------------------------------------------------------

* Update src/Illuminate/Database/Schema/Builder.php

* Apply suggestions from code review
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Sep 24, 2025
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Sep 24, 2025
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
	- preg_match(): Passing null to parameter laravel#2 ($subject) of type string is deprecated
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
-  Passing null to parameter laravel#2 ($subject) of type string is deprecated
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
-  Passing null to parameter laravel#2 ($subject) of type string is deprecated
tivvie added a commit to mogic-le/php84-laravel-framework-11 that referenced this pull request Nov 3, 2025
-  Passing null to parameter laravel#2 ($subject) of type string is deprecated
mvpopuk pushed a commit to mvpopuk/framework that referenced this pull request Nov 21, 2025
Pivoted analysis from fixes to new features and API improvements.
Identified 60+ high-value feature opportunities across 6 categories:

KEY FINDINGS:
- 15 API symmetry gaps (missing counterpart methods)
- 10 missing Blade directives for common patterns
- 8 missing validation rules
- 20+ missing testing helpers
- 15 Artisan command enhancements
- 11 convenience methods to reduce verbose patterns

TOP 5 FEATURE OPPORTUNITIES:

laravel#1: Add unless* methods to Stringable (IMPACT: 9/10, MERGE: 10/10)
- Stringable has 15 when* methods but ZERO unless* counterparts
- Collection already has unlessEmpty/unlessNotEmpty
- Perfect API symmetry opportunity

laravel#2: Add @Active Blade directive (IMPACT: 10/10, MERGE: 9/10)
- Used in 95%+ of Laravel apps for navigation
- Reduces verbose ternaries: @Active(condition) vs {{ condition ? 'active' : '' }}
- 30-100 lines saved per navigation component

laravel#3: Add --json to queue:failed command (IMPACT: 9/10, MERGE: 9/10)
- Critical for CI/CD pipelines and monitoring
- Follows recent pattern (schedule:list got --json in Nov 2025)

laravel#4: Add filtering to queue:failed (IMPACT: 9/10, MERGE: 9/10)
- Currently zero options, shows ALL jobs (could be thousands)
- Add --queue, --connection, --after, --class filters
- Follows route:list gold standard pattern

laravel#5: Add phone/positive/negative validation rules (IMPACT: 8/10, MERGE: 9/10)
- 'encoding' rule just added Nov 2025 - same pattern
- Phone is top 5 most common regex validation
- Number sign validation in 50%+ of business apps

RECENT FEATURE ACCEPTANCE PATTERNS:
- API symmetry additions: ~100% merge rate
- Small Blade directives: 90%+ acceptance
- Validation rules: 85%+ acceptance
- Command enhancements: 80%+ acceptance
- Testing helpers: 90%+ acceptance

Document includes:
- Top 15 ranked features with implementation details
- 5-phase implementation roadmap (6 months)
- Ready-to-submit PR template for first feature
- Code examples and file locations for each
- Recent merge patterns analysis
- Success factors and what to avoid

Total estimated: 50+ feature PRs over 6 months
GianfriAur added a commit to GianfriAur/framework that referenced this pull request Mar 4, 2026
[UPD] Route name alias laravel#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants