[5.3] Fix storedAs virtualAs#16683
Merged
taylorotwell merged 1 commit intolaravel:5.3from Dec 7, 2016
fernandobandeira:5.3
Merged
[5.3] Fix storedAs virtualAs#16683taylorotwell merged 1 commit intolaravel:5.3from fernandobandeira:5.3
taylorotwell merged 1 commit intolaravel:5.3from
fernandobandeira:5.3
Conversation
|
It would be nice to mention this in the documentation. It's just lucky that I happened to notice that my generated columns were lacking their constraints before deploying to production! I am running MySQL, which does support this feature. I'm on Laravel 5.5, not sure if this has changed in later versions. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16643
Currently the Grammar is appending
not nullandnullwhen generating thevirtualAsandstoredAscolumns.This is an invalid syntax since these are generated columns so you can't use that, currently it's throwing:
Example of current sql:
after this fix