• Laravel Version: master
• PHP Version: irrelevant
• Database Driver & Version: irrelevant

Description:

Following this trace:

Then reaching getMinutes:

Then parseDateInterval:

Which is defined as follows:

There are some type issues here:

1. Illuminate\Cache\Repository#put() has a possible null as TTL
2. Illuminate\Cache\Repository#getMinutes() does not accept null as TTL, but can return null
3. Illuminate\Support\InteractsWithTime#parseDateInterval() does not support null parameters

Besides being a type declaration issue, this leads to the weird side-effect of calling Illuminate\Cache\Repository#put('foo', 'bar', null) being valid, yet not producing a cache entry.

Another (worse) design issue is that Illuminate\Cache\Repository#put('foo', 'bar') (no third argument) is valid according to specification, but effectively dead/misleading code.

This is a design issue strictly related with #10504

Possible fixes

A possible fix is to:

• introduce a deprecation warning for null being passed to the method
• add a throwing assertion on the given parameter, so that the 5 supported types of CacheRepository::put() are checked
• remove support for null in a major release (6.0)

The assertion is completely optional, as a type check in userland would suffice, but the interface is indeed too broad due to the type being too extensive.