perf: change some container source when in china#1905
Merged
bestlong merged 19 commits intolaradock:masterfrom Dec 6, 2019
Merged
perf: change some container source when in china#1905bestlong merged 19 commits intolaradock:masterfrom
bestlong merged 19 commits intolaradock:masterfrom
Conversation
mouyong
changed the title
mouyong
changed the title
mouyong
changed the title
mouyong
changed the title
Member
|
.gitignore nginx/ssl is no need by this issues. |
Contributor
Author
Every one maybe have some local ssl file, I think it no need to submit. |
Mahmoudz
force-pushed
the
master
branch
4 times, most recently
from
0da1a63 to
58d1eb8
Compare
mouyong
changed the title
Mahmoudz
force-pushed
the
master
branch
4 times, most recently
from
134c78a to
493fc1a
Compare
Mahmoudz
force-pushed
the
master
branch
5 times, most recently
from
8f3e42d to
73109e8
Compare
added 5 commits
December 5, 2019 11:11
mouyong
commented
Dec 5, 2019
Contributor
Author
mouyong
left a comment
mouyong
left a comment
There was a problem hiding this comment.
myself review finished.
mouyong
changed the title
Contributor
Author
@bestlong it remove from this PR. |
Member
|
Don't mix in Is not change source fix |
Contributor
Author
|
What do you mean? I didn't understand. @bestlong |
Member
|
一個 PR 的範圍不要混雜不同的修改目的 處理 CHANGE SOURCE 就好, 不要同時修改 xdebug 的設定與變更 nginx 預設 site 檔案名稱 |
Contributor
Author
|
好的。理解了，谢谢您这么清晰的指出问题。已修改。 @bestlong 想请问下，之前的 xdebug.ini 配置，是否允许提交到主库呢？ |
Contributor
Author
3 tasks
Contributor
|
@mouyong 基于ubuntu 的镜像还是有一些的，在 lnmp 中用到最多的还是 workspace，可以说 workspace 的使用体验在用户是否选用 laradock 作为本地开发环境的选择中占了一部分比重。我觉得在 workspace 增加对中国友好的镜像切换 shell，是比较好的。 |
Contributor
Author
|
好的，了解了 @amorZhu |
This was referenced Dec 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I completed the 3 steps below: