fix: isolate backwards invocation contexts - #788
Merged
fatelei merged 1 commit intoAug 4, 2026
Conversation
Return a context-bound invocation copy for each manager request so canceled plugin sessions cannot affect subsequent calls to Dify internal APIs.
fatelei
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PluginManagercurrently returns one sharedBackwardsInvocation. Plugin sessions mutate that instance with their HTTP request context. After a request finishes, its canceled context can therefore leak into later endpoint setup or listing calls, causing/inner/api/invoke/encryptto fail locally withcontext canceledbefore the request reaches Dify API.Fixes #787
Root cause
Session.propagateTraceContextcallsSetContexton the invocation returned byPluginManager. Because the manager returned its stored singleton directly, the session replaced the singleton's context. The canceled request context then remained attached to all later callers.Changes
WithContextto create a context-bound invocation copy while reusing the HTTP client and immutable configurationPluginManager.BackwardsInvocation()Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Validation performed locally:
The full unit test suite and focused race tests pass. A control test on the unmodified
mainbranch reproduces the samecontext cancelederror, while the patched branch completes the request successfully.