Skip to content

fix: inject uv related environment variables to plugin process - #770

Merged
QuantumGhost merged 1 commit into
langgenius:mainfrom
fatelei:issue-768
Jul 13, 2026
Merged

fix: inject uv related environment variables to plugin process#770
QuantumGhost merged 1 commit into
langgenius:mainfrom
fatelei:issue-768

Conversation

@fatelei

@fatelei fatelei commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

fix #768

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added bug Something isn't working go Pull requests that update go code size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the environment configuration for the Python environment setup command to inherit the parent process's environment variables using os.Environ(). The reviewer pointed out that explicitly appending PATH is redundant because it is already included in os.Environ(), and suggested removing it to avoid duplicate entries.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/core/local_runtime/setup_python_environment.go Outdated
@fatelei
fatelei force-pushed the issue-768 branch 2 times, most recently from 3dca322 to c5c4332 Compare July 13, 2026 02:44
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 13, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2026
@QuantumGhost
QuantumGhost merged commit 42c2228 into langgenius:main Jul 13, 2026
7 checks passed
@QuantumGhost QuantumGhost changed the title fix: fix subprocess not inherit parent process env fix: inject uv related environment variables to plugin process Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install your own plugins on the intranet and configure UV account passwords and Nexus certificates using environment variables.

2 participants