Skip to content

fix: fix update plugin query plugin not use source - #763

Merged
fatelei merged 2 commits into
langgenius:mainfrom
fatelei:issue-762
Jul 2, 2026
Merged

fix: fix update plugin query plugin not use source#763
fatelei merged 2 commits into
langgenius:mainfrom
fatelei:issue-762

Conversation

@fatelei

@fatelei fatelei commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

fix #762

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working go Pull requests that update go code plugin-daemon labels Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances session cache diagnostics by introducing helper functions to classify cache errors and including detailed hints in logs and error messages. It also adjusts several log levels, handles write/close errors in the serverless handler, and updates the plugin upgrade logic to properly persist the installation source. A review comment correctly points out that a successful session caching event is logged at the Warn level instead of Info, which should be fixed to prevent false positives in log monitoring.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/core/session_manager/session.go
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2026
@fatelei
fatelei merged commit 10d95d3 into langgenius:main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upload local plugin and then update in marketplace will lead plugin not found

2 participants