feat: support onboarding ui - #753
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new endpoint to list plugins by category, adds the primary task object to the plugin installation response, and includes corresponding unit tests. The review feedback suggests several improvements: refactoring the ListPlugins function to reuse the new pluginInstallationResponse struct to eliminate code duplication, guarding against negative values for skippedMatches in the service layer, making the category listing more robust by skipping plugins that fail to load instead of failing the entire request, and leveraging the oneof validator tag in the controller for category validation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| return exception.BadRequestError(errors.New("invalid plugin category")).ToResponse() | ||
| } | ||
|
|
||
| skippedMatches := (page - 1) * page_size |
There was a problem hiding this comment.
If page is less than 1, skippedMatches can result in a negative value. Although the controller validates page >= 1, it is safer to guard against this in the service layer to prevent potential negative index issues if called from other contexts.
| skippedMatches := (page - 1) * page_size | |
| skippedMatches := 0 | |
| if page > 1 { | |
| skippedMatches = (page - 1) * page_size | |
| } |
| if err != nil { | ||
| return exception.InternalServerError(err).ToResponse() | ||
| } |
There was a problem hiding this comment.
If helper.CombinedGetPluginDeclaration fails for any single plugin installation (e.g., due to corrupted files or missing cache), the entire ListPluginsByCategory API will fail with a 500 Internal Server Error. To make the API more robust, consider skipping the corrupted plugin so that the rest of the tenant's plugins can still be loaded successfully.
| if err != nil { | |
| return exception.InternalServerError(err).ToResponse() | |
| } | |
| if err != nil { | |
| continue | |
| } |
This reverts commit bf16b52.
dosubot
Bot
added
size:L
2 participants
Description
Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format
Fixes #123orCloses #123.Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.