Skip to content

feat: regenerate requirement.txt - #720

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-719
Apr 29, 2026
Merged

feat: regenerate requirement.txt#720
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-719

Conversation

@fatelei

@fatelei fatelei commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Description

fix #719

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request go Pull requests that update go code labels Apr 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automatic requirements.txt generation for Python plugins by leveraging uv export when a uv.lock file is present. The packaging logic was refactored to support this, including updates to the Python template and the addition of a Root method to the filesystem decoder. Feedback focused on improving the robustness of the external command execution by adding timeouts via exec.CommandContext and enhancing error reporting for cases where the uv command fails without stderr output.

Comment thread pkg/plugin_packager/packager/packager.go
Comment thread pkg/plugin_packager/packager/packager.go
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2026
@fatelei
fatelei merged commit 26a6710 into langgenius:main Apr 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: package Python plugins with uv lock dependencies

2 participants