feat: add subcommand extract to slim - #716
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an extract command to the slim CLI tool, enabling the extraction of plugin schemas and declarations from either local files or a remote daemon. It includes new CLI command handling, refactored configuration loading with specific defaults for extraction, and new service logic for performing the extraction. A new API endpoint /v2/invoke/extract is also added to the daemon. Review comments suggest ensuring pluginWorkingPath is properly defined or replaced with filepath.Join, closing FSPluginDecoder instances for resource management, using uuid.Nil.String() for consistency, and optimizing local plugin package reading to avoid loading large files entirely into memory.
41tair
marked this pull request as ready for review
May 7, 2026 03:02
dosubot
Bot
added
size:XL
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
fatelei
reviewed
May 7, 2026
fatelei
reviewed
May 7, 2026
fatelei
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the extract as sub command for daemon, used for extract plugin schema.
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.