Skip to content

fix: fix some panic and fix test failed - #715

Merged
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-714
Apr 28, 2026
Merged

fix: fix some panic and fix test failed#715
fatelei merged 1 commit into
langgenius:mainfrom
fatelei:issue-714

Conversation

@fatelei

@fatelei fatelei commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

fix #714

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working go Pull requests that update go code plugin-daemon labels Apr 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces initialization checks for remote plugin runtimes, adds panic recovery and thread-safe write operations to the serverless transaction handler, and refactors tests for improved robustness. Feedback focuses on a potential memory leak in the debugger disconnection logic where an early return prevents map cleanup, as well as the premature setting of HTTP status codes and headers which may lead to inconsistent error responses and log warnings.

Comment thread internal/core/control_panel/server_debugger.go
Comment thread internal/core/io_tunnel/backwards_invocation/transaction/serverless_handler.go Outdated
Comment thread internal/core/io_tunnel/backwards_invocation/transaction/serverless_handler.go Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2026
@fatelei
fatelei merged commit 90abf86 into langgenius:main Apr 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some panic error

2 participants